fix: CallDeferred with SkeletonInstance#1518
Open
ArneGudermann wants to merge 1 commit into
Open
Conversation
phorward
requested changes
Jul 10, 2025
phorward
left a comment
phorward
left a comment
Member
There was a problem hiding this comment.
I also stumbled across this about a year ago and decided at the time that this problem could not be solved.
It's precisely about these edge cases: What if, for example, a subskel or even ActionSkel with a different bone order is put in here? Then there is no child and a skeletonByKind also fails.
I would therefore like to open this topic for discussion.
Comment on lines
+50
to
+52
| data = obj.dbEntity | ||
| if data is None: | ||
| data ={} |
Member
There was a problem hiding this comment.
Suggested change
| data = obj.dbEntity | |
| if data is None: | |
| data ={} | |
| data = obj.dbEntity or {} |
| if data is None: | ||
| data ={} | ||
| return { | ||
| ".__entity__": ViURJsonEncoder.preprocess(dict(data)), |
Member
There was a problem hiding this comment.
db.Entity inherits from dict. I think this is obsolete, but please test.
Suggested change
| ".__entity__": ViURJsonEncoder.preprocess(dict(data)), | |
| ".__entity__": ViURJsonEncoder.preprocess(data), |
| return entity | ||
| elif len(obj) == 3 and all(k in obj for k in (".__entity__", ".__key__", ".__skel__")): | ||
| from viur.core.skeleton.utils import skeletonByKind | ||
| skel = skeletonByKind(obj[".__skel__"])() |
Member
There was a problem hiding this comment.
What if a subskel of a given kind was provided? This won't work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1390