Skip to content

fix(brew): add assume_yes support#2090

Merged
GideonBear merged 1 commit into
topgrade-rs:mainfrom
uwuclxdy:yes-brew
Jun 20, 2026
Merged

fix(brew): add assume_yes support#2090
GideonBear merged 1 commit into
topgrade-rs:mainfrom
uwuclxdy:yes-brew

Conversation

@uwuclxdy

@uwuclxdy uwuclxdy commented Jun 13, 2026

Copy link
Copy Markdown
Member

What does this PR do

This PR makes topgrade pass -y to brew cask and formula steps when assume_yes = true.

Fixes #2088

Standards checklist

  • The PR title is descriptive
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself, with the relevant tools installed. If yes, add Topgrade's output of the relevant steps.
  • If this PR introduces new user-facing messages they are translated

AI involvement

None.

@adbario could you test this pretty please?

@GideonBear GideonBear changed the title fix(brew): pass -y when assume_yes = true fix(brew): add assume_yes support Jun 13, 2026
@GideonBear GideonBear added the needs verification The solution to this issue needs to be verified as working label Jun 13, 2026
@hesaratha

Copy link
Copy Markdown
── 13:29:01 - Brew ─────────────────────────────────────────────────────────────
DEBUG Executing command `/home/linuxbrew/.linuxbrew/bin/brew update`
==> Updating Homebrew...
Already up-to-date.
DEBUG Executing command `/home/linuxbrew/.linuxbrew/bin/brew upgrade --formula -y`
==> Upgrading 1 outdated package:
wget 1.21.4 -> 1.25.0
==> Fetching downloads for: wget
✔︎ Bottle wget (1.25.0)                                                                                                                                             Preparing     1.7MB/  1.7MB
==> Upgrading wget
  1.21.4 -> 1.25.0
==> Pouring wget--1.25.0.x86_64_linux.bottle.1.tar.gz
Warning: This keg was marked linked already, continuing anyway
🍺  /home/linuxbrew/.linuxbrew/Cellar/wget/1.25.0: 92 files, 4.8MB
==> Running `brew cleanup wget`...
Disable this behaviour by setting `HOMEBREW_NO_INSTALL_CLEANUP=1`.
Hide these hints with `HOMEBREW_NO_ENV_HINTS=1` (see `man brew`).
Removing: /home/linuxbrew/.linuxbrew/Cellar/wget/1.21.4... (92 files, 4.8MB)
==> Upgraded 1 outdated package
wget 1.21.4 -> 1.25.0
DEBUG Step "Brew Cask"
DEBUG Detected "/home/linuxbrew/.linuxbrew/bin/brew" as "brew"
DEBUG linuxbrew_directory owner_id: 1000, current_id: 1000
DEBUG Executing command `/home/linuxbrew/.linuxbrew/bin/brew --version`

── 13:29:04 - Brew - Cask ──────────────────────────────────────────────────────
DEBUG Executing command `/home/linuxbrew/.linuxbrew/bin/brew --repository buo/cask-upgrade`
DEBUG Executing command `/home/linuxbrew/.linuxbrew/bin/brew upgrade --cask -y`
DEBUG Step "config-update"
DEBUG Step "am"
DEBUG Step "appman"
DEBUG Step "deb-get"
DEBUG Step "toolbx"
DEBUG Detected "/usr/bin/toolbox" as "toolbox"

Tested and seems to work for me

@GideonBear GideonBear removed the needs verification The solution to this issue needs to be verified as working label Jun 20, 2026
@GideonBear GideonBear merged commit 96cb4ff into topgrade-rs:main Jun 20, 2026
24 checks passed
@github-actions github-actions Bot mentioned this pull request Jun 19, 2026
@uwuclxdy uwuclxdy deleted the yes-brew branch June 20, 2026 07:29
@uwuclxdy

Copy link
Copy Markdown
Member Author

@hesaratha thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Homebrew now prompts for confirmation by default: topgrade should pass --no-ask

3 participants