perf: optimize simple object destructuring in @const tags#18390
Open
omecreates wants to merge 2 commits into
Open
perf: optimize simple object destructuring in @const tags#18390omecreates wants to merge 2 commits into
omecreates wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: e0c9836 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a
TODOinConstTag.jsregarding the optimization of simple object pattern matching cases like{@const { x } = y}.Previously, this case forced the destructuring and subsequent repackaging of identical properties into a new object. This PR introduces a check (
is_simple_object_pattern) to identify when anObjectPatterncontains only simplePropertynodes matching keys to values without defaults or renaming. When this condition is met, the block now simply returns the right-hand-side initialization expression directly, avoiding the unnecessary reallocation.(Also includes a minor typo fix in
acorn.js)