Skip to content

refactor(types): ensure Global Config options are in correct places#44100

Draft
jamietanna wants to merge 1 commit into
mainfrom
fix/global-all-
Draft

refactor(types): ensure Global Config options are in correct places#44100
jamietanna wants to merge 1 commit into
mainfrom
fix/global-all-

Conversation

@jamietanna

Copy link
Copy Markdown
Contributor

Co-authored-by: Claude Sonnet 4.6 jamie.tanna+claude-code@mend.io

Changes

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

Details
40 files changed. The changes are complete and all tests pass. Here's a summary of what was done:

**`RepoGlobalConfig` and `GlobalConfig.OPTIONS` additions:**
- `checkedBranches`, `configValidationError`, `forkCreation`, `forkOrg`, `forkToken`, `inheritConfig`, `inheritConfigFileName`, `inheritConfigRepoName`, `inheritConfigStrict`, `onboardingRebaseCheckbox`, `optimizeForDisabled`, `persistRepoData`, `productLinks`, `reportFormatting`, `reportPath`, `reportType`, `repositoryCache`, `repositoryCacheType`, `unicodeEmoji`

**Fields removed from their old interfaces:**
- From `RenovateSharedConfig`: `configValidationError`, `productLinks`, `repositoryCache`, `repositoryCacheType`, `unicodeEmoji`
- From `LegacyAdminConfig`: `onboardingRebaseCheckbox`, `optimizeForDisabled`, `persistRepoData`
- From `RenovateConfig`: `forkToken`, `inheritConfig*`, `checkedBranches`, `reportFormatting/Path/Type`, `s3Endpoint`, `s3PathStyle`, `configFileNames`, `toolSettings` (the last four were already in `RepoGlobalConfig` but duplicated)
- From `RepoParams`: `forkToken`, `forkCreation`, `forkOrg`

**`InheritConfig`** was already complete — all 11 `globalOnly && inheritConfigSupport` options were already present.

**Access patterns updated** in ~20 source files to use `GlobalConfig.get('fieldName')` instead of `config.fieldName`. All test files updated to use `GlobalConfig.set({...})` instead of setting these properties directly on config objects.

Co-authored-by: Claude Sonnet 4.6 <jamie.tanna+claude-code@mend.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant