feat(platforms/bitbucket): validate API returns using schemas#43942
Draft
secustor wants to merge 7 commits into
Draft
feat(platforms/bitbucket): validate API returns using schemas#43942secustor wants to merge 7 commits into
secustor wants to merge 7 commits into
Conversation
Migrate all getJsonUnchecked calls in Bitbucket Cloud platform and bitbucket-tags datasource to use Zod-validated getJson calls. Added new Zod schemas to lib/modules/platform/bitbucket/schema.ts for Account, RepoBranchingModel, BranchResponse, BitbucketStatus, PrResponse, EffectiveReviewer, Comment, BbIssue, and a reusable PagedResult helper. Created lib/modules/datasource/bitbucket-tags/schema.ts with BitbucketTag, BitbucketCommit, BitbucketTagsResult, and BitbucketCommitsResult schemas. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> # Conflicts: # lib/modules/datasource/bitbucket-tags/index.ts # lib/modules/datasource/bitbucket-tags/schema.ts
- Make `PrResponse.links` and `updated_on` optional (API field used for
caching but not always populated in test fixtures)
- Make `Comment.id` and `Comment.user` optional to handle partial comment
objects (not all comments have both fields in all contexts)
- Make `EffectiveReviewer.type` and `reviewer_type` optional
- Add `UserInfo` schema for the `/2.0/users/{uuid}` endpoint (only needs
`account_status`, not the full `Account` shape)
- Make `BitbucketTag.target.hash` optional (not needed when listing tags,
only for single-tag digest lookups)
- Update `types.ts` to mark `PrResponse.links` and `updated_on` optional
- Update `pr-cache.ts` to handle optional `updated_on` in reconcile logic
- Guard `comment.user` access in `findPr` before calling workspace check
- Update test fixtures to include `created_on`, `title` where missing
- Fix `updatePr` test mocks to return valid `PrResponse` for single PR
- Fix `createPr` local variable naming to avoid TDZ with global `pr`
- Update `getPrList > filters PR list by author` snapshot
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Changes all Json requests where we read the Body to schema validated variants
This PR contains only BitBucket Cloud changes
Context
03/13
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: