feat(cache): use binary envelopes for package cache writes#43922
Open
zharinov wants to merge 2 commits into
Open
feat(cache): use binary envelopes for package cache writes#43922zharinov wants to merge 2 commits into
zharinov wants to merge 2 commits into
Conversation
b36416a to
de2d2a5
Compare
Collaborator
Author
|
This is smooth for the SQLite and Redis backends. For the |
The file backend's cleanup decides what to keep from cacache index metadata alone, so legacy entries (which store expiry inside the payload) would all be purged on the first sweep after upgrade, cooling the cache. Add a best-effort `upgradeLegacyEntry` hook on the base class, overridden only by the file backend, that rewrites a still-valid legacy entry as an envelope with the same expiry when it is read. The working set converts itself during the run, so it survives cleanup. Redis and SQLite govern expiry natively and inherit the no-op default.
Collaborator
Author
|
Just updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Package cache writes store binary envelopes instead of JSON-wrapped base64 strings.
PackageCacheBaseownsset(). It encodes the value into an envelope and passes the bytes to the backend'swriteRaw().EX.datablob and keeps its expiry column.cacacheand stores expiry in the index metadata.cacacheindex metadata. It no longer opens and parses every content file, and the in-memory expiry map is gone.Reads still fall back to the legacy JSON-wrapper decoder, so existing entries keep working.
legacy.tsstays until pre-envelope entries age out.Notes:
Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: N/A — local Redis smoke tests covered single-node Redis and a 3-node Redis cluster.