Skip to content

Fix non-padded month parsing for ISO-8601. Also added test. #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tersers wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix non-padded month parsing for ISO-8601. Also added test. #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f5134d
Support common parsing of month-only dates. Also added tests. Fixes #286
tasos-ukko Oct 20, 2018
1195beb
Remove unnecessary print
tasos-ukko Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pendulum/parsing/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@
# Date (optional)
"^"
"(?P<date>"
" (?P<classic>" # Classic date (YYYY-MM-DD)
" (?P<classic>" # Classic date (YYYY:MM:DD) or (YYYY-MM-DD) or (YYYY/MM/DD)
" (?P<year>\d{4})" # Year
" (?P<monthday>"
" (?P<monthsep>[/:])?(?P<month>\d{2})" # Month (optional)
" ((?P<daysep>[/:])?(?P<day>\d{2}))" # Day (optional)
" (?P<monthsep>[/:-])?(?P<month>\d{1,2})" # Month (optional)
" ((?P<daysep>[/:-])?(?P<day>\d{1,2}))?" # Day (optional)
" )?"
" )"
")?"
Expand Down Expand Up @@ -160,7 +160,7 @@ def _parse_common(text, **options):
day = int(m.group("month"))
else:
month = int(m.group("month"))
day = int(m.group("day"))
day = int(m.group("day") or 1)

if not m.group("time"):
return date(year, month, day)
Expand Down
4 changes: 4 additions & 0 deletions tests/parsing/test_parsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,3 +680,7 @@ def test_exif_edge_case():
assert 15 == parsed.hour
assert 45 == parsed.minute
assert 28 == parsed.second

def test_month_padding():
# This shouldn't raise an exceptionf
pendulum.parse('2016-7')