fix: add options_page support to webextension transformer#10304
Open
karthikeyansundaram2 wants to merge 2 commits into
Open
fix: add options_page support to webextension transformer#10304karthikeyansundaram2 wants to merge 2 commits into
karthikeyansundaram2 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #10076
Adds support for the
options_pagemanifest key in Parcel's webextension transformer.What changed
options_pagein the webextension schemaoptions_pageas a dependency so the referenced HTML is bundledoptions_pageis preserved in the output manifest\n - the referencedoptions.htmlfile exists in distWhy
Currently Parcel supports keys like
devtools_page,side_panel.default_path, andoptions_ui.page, but not the legacy/single-pageoptions_pagekey. This causes valid webextension manifests usingoptions_pageto miss bundling/validation support.This patch keeps the change minimal and adds regression coverage.