refactor(gitrepo): drop FetchRemoteCommit global lock#38105
Open
lunny wants to merge 6 commits into
Open
Conversation
GiteaBot
added
the
lgtm/need 2
wxiaoguang
reviewed
Jun 14, 2026
wxiaoguang
reviewed
Jun 14, 2026
Zettat123
approved these changes
Jun 15, 2026
GiteaBot
added
lgtm/need 1
bircni
requested changes
Jun 17, 2026
| AddDynamicArguments(commitID)) | ||
| }) | ||
| // Avoid shared FETCH_HEAD and auto-maintenance side effects because callers only need the object data. | ||
| return RunCmd(ctx, repo, gitcmd.NewCommand("fetch", "--no-tags", "--no-write-fetch-head", "--no-auto-maintenance"). |
Member
There was a problem hiding this comment.
this requires git > 2.29 for --no-write-fetch-head - we should then require it in the modules/git/git.go too
GiteaBot
added
lgtm/blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FetchRemoteCommit only needs fetched objects to exist locally for
merge-base and compare operations. It does not rely on FETCH_HEAD or
local ref updates.
Use
git fetch --no-write-fetch-head --no-auto-maintenanceto avoidshared FETCH_HEAD side effects and reduce concurrent maintenance risk,
then remove the repo-wide global lock.
Add concurrent tests for fetching the same commit and different commits.