fix: handle AttributeError in trending command when running in Docker (fixes #138)#212
Open
algojogacor wants to merge 1 commit into
Open
Conversation
Fixes donnemartin#138 The gh trending command raises an AttributeError when running in Docker because the RSS feed from github-trends.ryotarai.info may be unreachable or return malformed entries without the expected attributes. Changes: - github.py: Wrap feedparser.parse() in try/except with user-friendly error message when network is unavailable - github.py: Check for None/empty entries before processing - table.py: Handle missing 'link' attribute in feed entries gracefully - formatter.py: Handle missing 'title' attribute in feed entries (extends the existing fix for missing 'summary' from PR donnemartin#129)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #138 -
gh trendingraises anAttributeErrorwhen running in Docker.Problem
The
gh trendingcommand fetches an RSS feed fromhttp://github-trends.ryotarai.info/rss/. When running in Docker (or when the network is unavailable), the feedparser returns malformed entries or fails entirely, causing anAttributeErrortraceback.While a previous fix (PR #129) added error handling for missing
summaryattributes, thetitleandlinkattributes remain unprotected, and the network fetch itself has no error handling.Changes
gitsome/github.pyfeedparser.parse()in try/except with a user-friendly error message when the network is unavailableNoneor emptyentriesbefore processinggitsome/table.pylinkattribute in feed entries gracefully (catchesKeyError,IndexError, andAttributeError)gitsome/formatter.pytitleattribute in feed entries gracefully (extends the existing fix for missingsummaryfrom PR Fix trending command to handle empty summaries #129)Testing
gh trendingnow shows a friendly error message instead of a traceback when the RSS feed is unreachabletitle,link, orsummary) are handled gracefully