Skip to content

Expose FSVideoRenderView.h#53

Closed
MarkBorazio wants to merge 1 commit into
debugly:mainfrom
MarkBorazio:Expose-FSVideoRenderView
Closed

Expose FSVideoRenderView.h#53
MarkBorazio wants to merge 1 commit into
debugly:mainfrom
MarkBorazio:Expose-FSVideoRenderView

Conversation

@MarkBorazio

Copy link
Copy Markdown

I need to be able to render the same video to multiple UIViews at the same time. There is a sample for exactly this use case, however when importing FSPlayer as a library FSMetalView is not publicly exposed.

Given that all I need is to be able to create an instance of UIView<FSVideoRenderingProtocol>, I figured that it would be better to add FSVideoRenderView.h to the umbrella header so that there is the option to create instances of either the GL view or Metal view.

@debugly

debugly commented Nov 5, 2025

Copy link
Copy Markdown
Owner

FSVideoRenderView.h was already added to FSPlayerKit.h, The unbrella header is FSPlayerKit.h not FSPlayer.h .

#import <FSPlayer/FSPlayerKit.h>

@debugly debugly closed this Nov 5, 2025
@MarkBorazio

Copy link
Copy Markdown
Author

Thanks for the feedback @debugly .

Please forgive me if I am missing something here, but when I manually create the framework the resulting module map file specifies FSPlayer.h as the umbrella header. As far as I know when no module map is specified then Xcode creates a default one where it uses the project name for the umbrella header. As a result when I import this using my own personal SPM package, I only have access to the FSPlayer.h

If you want, I can submit another PR that manually specifies a module map with FSPlayerKit.h as the header.

@debugly

debugly commented Nov 6, 2025

Copy link
Copy Markdown
Owner

Please submit another PR.

@MarkBorazio

Copy link
Copy Markdown
Author

See #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants