fix: handle public-only Bip32ECKeyPair to avoid NullPointerException in deriveChildKey#2284
Open
Dev10-sys wants to merge 2 commits into
Open
fix: handle public-only Bip32ECKeyPair to avoid NullPointerException in deriveChildKey#2284Dev10-sys wants to merge 2 commits into
Dev10-sys wants to merge 2 commits into
Conversation
…p32ECKeyPair Signed-off-by: Dev10-sys <kalpanagola9897@gmail.com>
…y-derive-npe # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a NullPointerException when deriving child keys from a Bip32ECKeyPair created with only a public key.
Previously, getPublicKeyPoint() always tried to derive the public point from the private key, which caused a crash when the private key was null.
Now, if the private key is not present, the public key is used to reconstruct the ECPoint directly.
A test case has been added to verify that public-only keypairs no longer throw an exception during derivation.
Fixes #1927