[K/N] Make kotlin-remove-sp a proper LLVM pass

[Alexander Shabalin (projedi)]

No description provided.

[kotlin-safemerge]

Code Owners

Rule	Owners	Approval
/​kotlin-​native/​	kotlin-native mMaxy projedi anton-bannykh sbogolepov DmT021 haitaka glukianets azakharenko homuroll SvyatoslavScherbina	❌ SvyatoslavScherbina

[Alexander Shabalin (projedi)]

/dry-run

[Build Server (KotlinBuild)]

THIS IS A DRY RUN

Quality gate is triggered at https://buildserver.labs.intellij.net/build/977499308 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-6301/safe-merge
Commit: 1fa9a8d

---

Quality gate finished successfully.

[Alexander Shabalin (projedi)]

Checked that between the old implementation, the new one and the fallback runLLVMPassesInCompiler=true, the generated bitcode didn't change in both optimized and optimized for small binary modes.

Also checked that the phase took the same time. However, something weird:

DYNAMIC PHASE     461 ms (llvm-remove-sp.ModuleToFunctionPassAdaptor)
DYNAMIC PHASE     455 ms (llvm-remove-sp.ModuleToFunctionPassAdaptor.PassManager<Function>)
DYNAMIC PHASE     437 ms (llvm-remove-sp.ModuleToFunctionPassAdaptor.PassManager<Function>.kotlin::RemoveRedundantSafepointsPass)
DYNAMIC PHASE       0 ms (llvm-remove-sp.ModuleToFunctionPassAdaptor.InnerAnalysisManagerProxy<FunctionAnalysisManager, Module>)
DYNAMIC PHASE    5904 ms (RemoveRedundantSafepoints)

maybe our llvm pass measurement is faulty. EDIT: the phase time included LLVM module dump, skewing the result; remeasured

The phase time improved by ~10%, the fallback version is faster by ~10% on top of that and matches LLVM pass time. So, the difference between llvm pass and the callback comes from the separate LLVMKotlinRunPasses call; which hints, that some compiler phases should be squashed together into a single one, that combines passes in a single call to LLVMKotlinRunPasses (trying to squash all LLVM phases into a single one is probably too limiting, requires some research).