LONDON SDC | Anna Fedyna | Module-Tools | Week 3 | Implemented Shell Commands in JS#48
Open
annafedyna wants to merge 10 commits into
Open
LONDON SDC | Anna Fedyna | Module-Tools | Week 3 | Implemented Shell Commands in JS#48annafedyna wants to merge 10 commits into
annafedyna wants to merge 10 commits into
Conversation
ehwus
reviewed
Mar 29, 2025
ehwus
left a comment
There was a problem hiding this comment.
This is a great effort Anna that shows a good understanding of creating command line programs in Node, as well as good knowledge of the shell programs themselves. Formatting your code would make it easier to read and should be quite easy for you to set up, and working with data like files it's always important to be mindful of the operations we are making - always be thinking whether we can iterate fewer times, as when the files are large these can be very costly operations.
Author
|
@ehwus Thank you for your review! I really appreciate you highlighting important moments that need more attention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.