London| Elhadj Abdoul Diallo| Module-Tools | WEEK1 - Individual-shell-tools by eediallo · Pull Request #16 · CodeYourFuture/Module-Tools

eediallo · 2025-02-28T21:26:34Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

…4.sh

…04.sh

…t-01.sh

…per-files directory in script-02.sh

… in script-03.sh

…es in helper-files directory in script-04-stretch.sh

…t in script-01.sh

…t in script-02.sh

… files in helper-files directory in script-03.sh

…alogue.txt in script-01.sh

…dless of case) from dialogue.txt in script-02.sh

…nsensitive) in dialogue.txt in script-03.sh

…se insensitive) from dialogue.txt in script-04.sh

…preceding line from dialogue.txt in script-05.sh

…ines spoken by the Doctor

…s spoken by the Doctor (case insensitive)

…octor in all .txt files

…in input.txt using sed

…ipt-02.sh

…ut.txt in script-03.sh

…will" in input.txt in script-04.sh

…input.txt in script-05.sh

…xt in script-06.sh

…t in script-01.sh

…script-02.sh

…mpt score in script-03.sh

…n script-04.sh

…pt-05.sh

…cores in script-06-stretch.sh

… of their scores in script-07-stretch.sh

…' in dialogue.txt in script-03.sh

…he total of their scores in script-07-stretch.sh" This reverts commit 779cb97.

…ue.txt in script-03.sh

…Module-Tools into individual-shell-tools

… of their scores in script-07-stretch.sh

mjpeet

You're doing great with your scripts! Keep experimenting and practicing. Every script you write improves your skills. Don't hesitate to ask for help and keep up the fantastic work!

mjpeet · 2025-03-02T13:54:17Z

 # Your output should contain 6 lines, each with one word and one number on it.
 # The first line should be "Ahmed 1".
+
+awk '{print $1, $3}' scores-table.txt


how would your script look like if you used printf instead of print? what would be the advantage (if any) to use printf?

That's a good question! I've never tried printf before with awk but I guess it would allow me to format the result but as the content of the file is alreay in text format print is enough in this case

mjpeet · 2025-03-02T14:23:56Z

-# The first line should be "Ahmed 4".
+# Output the names of each player in London along with the score from their last attempt.
+# For lines with fewer than 5 columns, print the last column.
+awk '{if (NF >= 5 && $2 == "London") print $1, $5; else if (NF < 5 && $2 == "London") print $1, $NF}' scores-table.txt


wow, very nice work! (especially, because if you look at the current the latest changes for this in the repo, the condition for "For lines with fewer than 5 columns, print the last column." was taken out)

That's right!

mjpeet · 2025-03-02T14:34:58Z

 # TODO: Write a command to output just the names of each player along with the total of adding all of that player's scores.
 # Your output should contain 6 lines, each with one word and one number on it.
 # The first line should be "Ahmed 15". The second line should be "Basia 37"
+awk '{ for(i = 3; i <= NF; i++) sum += $i; print $1, sum; sum = 0 }' scores-table.txt


i noticed you set initial value for sum at the end of the block - would it be better to initialise sum in another way? (regardless, your solution does print out the correct solution!)

Yes, I could have done it at the biginning like this:

awk '{ sum= 0; for(i = 3; i <= NF; i++) sum += $i; print $1, sum}' scores-table.txt

mjpeet · 2025-03-02T14:45:25Z

 # 1 It looked delicious.
 # 2 I was tempted to take a bite of it.
 # 3 But this seemed like a bad idea...
+cat -n ../helper-files/helper-3.txt


how would this script look like if used the | (pipe) ?

We would have piped it to the nl command like this:

cat ../helper-files/helper-3.txt | nl

mjpeet · 2025-03-02T14:53:34Z


 # TODO: Write a command to output every line in dialogue.txt that contains the word Doctor (regardless of case).
 # The output should contain 9 lines.
+grep doctor -i dialogue.txt


when you look at the grep command man page, where are the grep options "positioned" compared to the parameters? (your solution works, but there may be commands where the order of the options and input(s) matters)

I agree, going to fix it by following the correct order: grep [OPTION...] PATTERNS [FILE...]

mjpeet · 2025-03-02T15:02:44Z


 # TODO: Write a command to output, for each `.txt` file in this directory, how many lines of dialogue the Doctor has.
 # The output should show that dialogue.txt contains 6 lines, dialogue-2.txt contains 2, and dialogue-3.txt contains 0.
+grep ^Doctor -icH *.txt


if you need to use the minimum of the options, how would your solution look like? (right now you're using 3)

I would remove the -H option and the result will still look the same

mjpeet · 2025-03-02T15:32:57Z

 # TODO: Write a command which _recursively_ lists all of the files and folders in this directory _and_ all of the files inside those folders.
 # The output should be a list of names including: child-directory, script-01.sh, helper-1.txt (and more).
 # The formatting of the output doesn't matter.
+cd ../ls


when you consider where this script (script-03.sh) is located, and where it would be executed, do you think this directory change is necessary?

It is not neccessary in this case. going to remove it.

mjpeet · 2025-03-02T15:35:43Z

 # The output should be a list of names in this order, one per line: helper-3.txt, helper-1.txt, helper-2.txt.

+cd ../ls/child-directory
+ls -1t


how would you modify this script if using the command cd is not an option? (do you "need" to use cd ?)

I can make it work without cd-ing

mjpeet · 2025-03-02T15:41:02Z

 # TODO: Write a command to output input.txt with all occurrences of the letter `i` replaced with `I`.
 # The output should contain 11 lines.
 # The first line of the output should be: "ThIs Is a sample fIle for experImentIng with sed.".
+sed s/i/I/g input.txt


what would the option -e mean for this script?

it specifies multiple editing commands in a single sed invocation. But is not needed in this case because there is only one command being executed.

mjpeet · 2025-03-02T15:51:32Z

 # If a line starts with a number and a space, make the line instead end with a space and the number.
 # So line 6 which currently reads "37 Alisha" should instead read "Alisha 37".
 # The output should contain 11 lines.
+sed -E 's/^([0-9]+) (.*)$/\2 \1/' input.txt


(optional) how would you change this script if you need to use basic regular expressions? (congrats on using ERE ! )

…in script-02.sh

…ipt-07.sh

…oving unnecessary cd

… files

…bility

mjpeet

thanks for getting back on the comments!

eediallo · 2025-03-03T09:59:57Z

Thank you @mjpeet for the review and constructive feedback.

[Elhadj Abdoul Diallo] added 30 commits February 26, 2025 10:19

ls --> Implement directory listing in script-01.sh

911cd92

ls --> Implement file listing in child-directory for script-02.sh

8b16334

ls --> Implement recursive file listing in script-03.sh

f062d6d

ls --> Implement file listing sorted by modification time in script-0…

18080a1

…4.sh

ls --> Implement file listing sorted in the opposite order in script-…

2798631

…04.sh

cat --> Implement command to output contents of helper-1.txt in scrip…

8467560

…t-01.sh

cat --> Implement command to output contents of all text files in hel…

68070ec

…per-files directory in script-02.sh

cat --> Implement command to output numbered contents of helper-3.txt…

1928e79

… in script-03.sh

cat --> Implement command to output numbered contents of all text fil…

336b8aa

…es in helper-files directory in script-04-stretch.sh

wc --> Implement command to output the number of words in helper-3.tx…

1211ee7

…t in script-01.sh

wc --> Implement command to output the number of lines in helper-3.tx…

50606f2

…t in script-02.sh

wc --> Add command to output word, line, and byte counts for all text…

5bb3577

… files in helper-files directory in script-03.sh

grep --> Implement command to output lines spoken by the Doctor in di…

c445a6b

…alogue.txt in script-01.sh

grep --> Implement command to output lines containing 'Doctor' (regar…

86617b7

…dless of case) from dialogue.txt in script-02.sh

grep --> Implement command to count lines containing 'Doctor' (case i…

65f3f5b

…nsensitive) in dialogue.txt in script-03.sh

grep --> Implement command to output lines not containing 'Hello' (ca…

ae357f2

…se insensitive) from dialogue.txt in script-04.sh

grep --> Implement command to output lines containing 'cure' and the …

eb4109f

…preceding line from dialogue.txt in script-05.sh

grep --> Implement command to output names of .txt files containing l…

988f5f9

…ines spoken by the Doctor

grep --> Update command to output names of .txt files containing line…

d47bfbb

…s spoken by the Doctor (case insensitive)

grep --> Implement command to count lines of dialogue spoken by the D…

dc54635

…octor in all .txt files

sed --> Implement command to replace all occurrences of 'i' with 'I' …

ec4ce2a

…in input.txt using sed

sed --> Implement command to remove all numbers from input.txt in scr…

7d99d30

…ipt-02.sh

sed --> Implement command to remove lines containing numbers from inp…

b79d94d

…ut.txt in script-03.sh

sed --> Implement command to replace occurrences of "We'll" with "We …

a7e7ada

…will" in input.txt in script-04.sh

sed --> Implement command to reorder lines starting with a number in …

08b42da

…input.txt in script-05.sh

sed --> Implement command to normalize spaces after commas in input.t…

e195344

…xt in script-06.sh

awk --> Implement command to output player names from scores-table.tx…

f8f08c5

…t in script-01.sh

awk --> Implement command to output player names and their cities in …

1e8bf64

…script-02.sh

awk --> Implement command to output player names and their first atte…

234070e

…mpt score in script-03.sh

awk --> Output player names in London with their last attempt score i…

f65408d

…n script-04.sh

[Elhadj Abdoul Diallo] added 8 commits February 26, 2025 15:19

awk --> Output player names along with their game play counts in scri…

df28eb6

…pt-05.sh

awk --> Implement command to output the total of all players' first s…

1a43a45

…cores in script-06-stretch.sh

awk --> Implement command to output player names along with the total…

779cb97

… of their scores in script-07-stretch.sh

awk --> update by using the -c flag to count lines containing 'Doctor…

7588543

…' in dialogue.txt in script-03.sh

Revert "awk --> Implement command to output player names along with t…

5715882

…he total of their scores in script-07-stretch.sh" This reverts commit 779cb97.

grep--> Simplify command to count lines containing 'Doctor' in dialog…

16e8e79

…ue.txt in script-03.sh

Merge branch 'individual-shell-tools' of https://github.com/eediallo/…

940f691

…Module-Tools into individual-shell-tools

awk --> Implement command to output player names along with the total…

3bb6a94

… of their scores in script-07-stretch.sh

eediallo added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 28, 2025

mjpeet reviewed Mar 2, 2025

View reviewed changes

[Elhadj Abdoul Diallo] added 6 commits March 2, 2025 19:19

cat --> Replace 'cat -n' with 'cat | nl' to number lines in script-03.sh

e2abd25

grep --> fix: Adjust grep command syntax for case-insensitive search …

3dba76e

…in script-02.sh

grep --> Fix command to count lines of dialogue for the Doctor in scr…

c544e75

…ipt-07.sh

ls --> fix: Simplify directory listing command in script-03.sh by rem…

7fe9ad0

…oving unnecessary cd

ls --> fix: Remove unnecessary cd command in script-01.sh for listing…

8828953

… files

fix: Use variable for directory path in script-04.sh to improve reada…

697e210

…bility

mjpeet reviewed Mar 2, 2025

View reviewed changes

Uh oh!

Conversation

eediallo commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Uh oh!

mjpeet left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eediallo Mar 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mjpeet left a comment

Choose a reason for hiding this comment

Uh oh!

eediallo commented Mar 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

eediallo commented Feb 28, 2025 •

edited

Loading

eediallo Mar 2, 2025 •

edited

Loading