Skip to content

pnpm(update-lockfile): grouped monorepo PR titled as an update but lockfile doesn't change the targeted package #43998

@RahulGautamSingh

Description

@RahulGautamSingh

Discussed in #43960

Originally posted by thasmo June 12, 2026

Description

When a grouped rangeStrategy: update-lockfile PR targets a package that pnpm silently refuses to bump (because of an internal peer constraint), Renovate still opens/keeps a PR whose title advertises the update. The branch ends up containing only unrelated transitive updates from pnpm install, while the targeted dependency is unchanged.

Renovate should verify the requested packageName@newVersion actually landed in the regenerated lockfile and not ship a misleadingly-titled PR otherwise.

Reproduction

PR: thasmo/website#739

Possible Fix

After regenerating the pnpm lockfile, for each isLockfileUpdate upgrade verify its packageName reached newVersion in the new lockfile.
If not:

  • don't push a lockfile artifact that contains only unrelated churn, and
  • surface it (artifact error / info log) rather than silently shipping a misleadingly-titled PR.

Logs

Check discussion. Logs were too long to post in PR description

Metadata

Metadata

Assignees

No one assigned

    Labels

    manager:npmpackage.json files (npm/yarn/pnpm)

    Type

    Priority

    Medium

    Regression introduced in

    None yet

    Datasource

    None yet

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions