Skip to content
This repository was archived by the owner on Jul 21, 2024. It is now read-only.
This repository was archived by the owner on Jul 21, 2024. It is now read-only.

Approved label added with 1 approval and 1 change request #244

@allout58

Description

@allout58

Summary

The approved label is added incorrectly when there is one approving review followed by one changes requested review.

Steps to reproduce

  1. Set up branch protections to require 1 (might not be relevant?)
  2. Request 2 reviews
  3. First reviewer approves the changes (should go to PR: partially-approved, which occurs)
  4. Second reviewer requests changes

Pull Request URL

Private repo unfortunately

What is the current bug behavior?

PR: reviewed-approved label is added

What is the expected correct behavior?

PR: reviewed-changes-requested label is added

Relevant logs and/or screenshots

pr-triage-approval-issue

Possible fixes

(If you have any idea to solve the problem, please help us.)
Most likely related to #223. I'm willing to take a crack at a PR in the future, but a little busy at the moment.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions